Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin anndata to fix tests on Windows #3410

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Pin anndata to fix tests on Windows #3410

merged 1 commit into from
Apr 11, 2023

Conversation

sir-sigurd
Copy link
Member

@sir-sigurd sir-sigurd commented Apr 11, 2023

Fixes recent CI failure:
https://github.com/quiltdata/quilt/actions/runs/4666597638/jobs/8261488533

It seems to be caused by the recent release of anndata 0.9.0.

scverse/anndata#969

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #3410 (7d42d62) into master (76272c0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3410   +/-   ##
=======================================
  Coverage   35.73%   35.73%           
=======================================
  Files         680      680           
  Lines       29668    29668           
  Branches     4376     4376           
=======================================
  Hits        10603    10603           
  Misses      17902    17902           
  Partials     1163     1163           
Flag Coverage Δ
api-python 91.17% <ø> (ø)
catalog 9.58% <ø> (ø)
lambda 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/python/setup.py 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sir-sigurd sir-sigurd changed the title Pin anndata to fix tests Pin anndata to fix tests on Windows Apr 11, 2023
@sir-sigurd sir-sigurd marked this pull request as ready for review April 11, 2023 11:41
@sir-sigurd sir-sigurd requested a review from nl0 April 11, 2023 11:48
@sir-sigurd sir-sigurd merged commit 4b01358 into master Apr 11, 2023
@sir-sigurd sir-sigurd deleted the fix-anndata-tests branch April 11, 2023 12:47
nl0 added a commit that referenced this pull request Apr 25, 2023
* master: (24 commits)
  Rename hash to hashOrTag because tag is also acceptable (#3430)
  Type for `theme.typography.monospace` (#3428)
  Fix thumbnail lambda CI fail (#3433)
  Add link from side navigation and update text (#3431)
  Add "unreleased" section, fix entry (#3429)
  Fix file URL for embed (#3419)
  Add snapshot test for BucketIcon (#3422)
  doc: fix push args line breaks (#3424)
  Fix thumbnail lambda CI job (#3426)
  Breadcrumbs refactoring (#3417)
  Switch debug-harness from token to code (#3418)
  pkgselect: Ensure path ends with slash (#3411)
  Suspense wrapper for ResourceCache (#3408)
  Make gendocs bash scripts fail loudly (#3414)
  Bump debian in /s3-proxy (#3415)
  Bump debian in /lambdas/thumbnail (#3416)
  Quilt3 v5.3.0 (#3413)
  Hotfix: status reports bucket exception (#3412)
  Add --no-copy parameter to Package.push() (#3398)
  Pin anndata to fix tests on Windows (#3410)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants